Skip to content

Conversation

@kebbet
Copy link
Contributor

@kebbet kebbet commented Mar 6, 2023

What?

Fixes #48142.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@gziolo
Copy link
Member

gziolo commented Mar 19, 2023

Thank you for opening this PR. It looks like a good start. I see two fixable issues reported on CI:

  1. Stylelint reports two errors with the updated config.
    Push styelint version in peerDependencies · WordPressgutenberg@a7b3252
  2. Two of the existing unit tests fail so we need to update them or remove if no longer make sense.
    Push styelint version in peerDependencies · WordPressgutenberg@a7b3252 2

@gziolo gziolo added [Tool] stylelint config /packages/stylelint-config [Type] Breaking Change For PRs that introduce a change that will break existing functionality labels Mar 19, 2023
@gziolo
Copy link
Member

gziolo commented May 16, 2023

There is more work necessary, as explored in #50336.

@gziolo
Copy link
Member

gziolo commented Aug 29, 2024

There is now another more up-to-date PR from @mikeybinns that is fully functional, ready for review and testing:

Thank you so much for your contribution!

@gziolo gziolo closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Tool] stylelint config /packages/stylelint-config [Type] Breaking Change For PRs that introduce a change that will break existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@wordpress/stylelint-config uses outdated stylelint (14.2)

2 participants