withFocusReturn: Convert to TypeScript #48748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Mar 3, 2023
| * @return Higher Order Component with the focus restauration behaviour. | ||
| */ | ||
| export default createHigherOrderComponent( | ||
| // @ts-expect-error TODO: Reconcile with intended `createHigherOrderComponent` types |
Member
Author
There was a problem hiding this comment.
This HOC was a bit irregular and requires a bit more effort to resolve with the upstream types, so I'll suppress it for now.
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 622c11b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4327017513
|
chad1008
reviewed
Mar 8, 2023
Contributor
chad1008
left a comment
chad1008
left a comment
There was a problem hiding this comment.
This was more of a learning experience than anything else for me, but it looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35744
What?
Convert the
withFocusReturnHOC to TypeScript.Why?
It isn't really necessary that these HOCs are typed at this point, but just converting them because they are pretty simple. We can
ts-nocheckany of the ones that are not worthwhile.Testing Instructions
✅ Static checks pass.