Framework: Drop the focus/setFocus props from block edit functions#4872
Merged
youknowriad merged 11 commits intomasterfrom Feb 7, 2018
Merged
Framework: Drop the focus/setFocus props from block edit functions#4872youknowriad merged 11 commits intomasterfrom
youknowriad merged 11 commits intomasterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of this PR is simple: We only have to worry about the position of the cursor when selecting a new block, everything else should be left as uncontrolled browser behavior.
Based on the above statement, this PR do:
focusprop from the blockeditfunction and replace it with anisSelectedpropsetFocuspropWritingFlowcomponent: When a new block is selected, move the cursor to the right positioneditfunction for backwards compatibility concerns now.This should simplify the block author's work a lot, not need to handle any focus behavior inside blocks.
Testing instructions
This needs heavy testing, all writing flow micro interactions should be tested.