Migrate switch-to-draft to Playwright#48120
Merged
kevin940726 merged 2 commits intotrunkfrom Feb 21, 2023
Merged
Conversation
kevin940726
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 74718d9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4229592408
|
t-hamano
approved these changes
Feb 16, 2023
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I think the nested loops made the code look cleaner 👍
Mamaduka
reviewed
Feb 17, 2023
Comment on lines
+33
to
+35
| [ 'schedule', 'publish' ].forEach( ( postStatus ) => { | ||
| [ 'large', 'small' ].forEach( ( viewport ) => { | ||
| [ 'post', 'page' ].forEach( ( postType ) => { |
Member
There was a problem hiding this comment.
This is a wild use for test loops, and I'm here for it 😄
Member
Author
There was a problem hiding this comment.
FWIW, it's what Playwright recommended too 😆 .
WunderBart
reviewed
Feb 17, 2023
Comment on lines
+124
to
+126
| content: `<!-- wp:paragraph --> | ||
| <p>This will be a scheduled ${ postType } edited in a ${ viewport } viewport</p> | ||
| <!-- /wp:paragraph -->`, |
Member
There was a problem hiding this comment.
What do you think about making those more readable like this?
content: [
`<!-- wp:paragraph -->`,
`<p>This will be a scheduled ${ postType } edited in a ${ viewport } viewport</p>`,
`<!-- /wp:paragraph -->`,
].join( '\n' ),Possibly also less chance that accidental leading whitespace will kick in.
Member
Author
There was a problem hiding this comment.
I actually think this is less readable 😅 . It's only three lines so I think it's fine. For longer content, I agree your solution works better. However, I think a better option might be to allow passing blocks to the createPost/createPage util and do the serializing automatically there. WDYT?
Member
There was a problem hiding this comment.
Yep, that would work even better! 😄
kevin940726
force-pushed
the
migrate/switch-to-draft-playwright
branch
2 times, most recently
from
43833d4 to
df91f45
Compare
kevin940726
force-pushed
the
migrate/switch-to-draft-playwright
branch
from
df91f45 to
74718d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851. Migrate
switch-to-draftto Playwright to address some of the flakiest tests. Hopefully closes #47499 and closes #47500.Why?
The
switch-to-drafte2e tests have been pretty flaky recently. After debugging the artifacts, it seems like they failed in an unrelated part when selecting dates in the scheduling date picker.How?
We already have a dedicated e2e test for scheduling posts or pages in
scheduling.test.js, hence we don't need to duplicate that logic here forswitch-to-drafttests.Furthermore, the original tests create published/scheduled posts and pages by interacting with the UI, which can be very slow and unnecessary. The refactored tests use REST API to create those posts and pages to speed up the tests.
Testing Instructions
CI should pass.
Screenshots or screencast