Merged
Conversation
kevin940726
added
the
[Type] Automated Testing
kevin940726
requested review from
Mamaduka,
aaronrobertshaw,
glendaviesnz and
t-hamano
kevin940726
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
|
Size Change: +1.05 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 32b51c9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4173876911
|
Co-authored-by: Glen Davies <[email protected]>
Member
Author
|
This one is ready for review now :). |
WunderBart
approved these changes
Feb 14, 2023
Member
WunderBart
left a comment
WunderBart
left a comment
There was a problem hiding this comment.
v1.30 yay! 🥳
I've left just a couple nit comments. Nice work, thank you! 🙌
Co-authored-by: Bart Kalisz <[email protected]>
aaronrobertshaw
approved these changes
Feb 15, 2023
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
LGTM 🚢
Special thanks for keeping on top of the best practices documentation 🙇
Member
|
Thank you, @kevin940726! |
ntsekouras
added
the
Backport to WP 6.9 Beta/RC
Contributor
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: be68ed7 |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 21, 2023
* Upgrade Playwright to 1.30.0 * Update doc for best practices * Fix snapshot path * Fix strict locator * Try to fix safari test * Update image test to use visual testing * Update docs/contributors/code/e2e/README.md Co-authored-by: Glen Davies <[email protected]> * Drop unnecessary await in toMatchSnapshot Co-authored-by: Bart Kalisz <[email protected]> --------- Co-authored-by: Glen Davies <[email protected]> Co-authored-by: Bart Kalisz <[email protected]>
ntsekouras
removed
the
Backport to WP 6.9 Beta/RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Upgrade Playwright to 1.30.0
Testing Instructions
CI should pass.