Navigation: Only show the deleted menu warning if a ref is specified #47699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
draganescu
approved these changes
Feb 2, 2023
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
Yes, that was an oversight. Thank you @scruffian
|
Size Change: -1 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 01d3dc3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4076132478
|
Mamaduka
pushed a commit
that referenced
this pull request
Feb 3, 2023
…47699) Co-authored-by: scruffian <[email protected]>
Member
|
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: 0101915 |
Mamaduka
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If a navigation block is in a fallback state, it displays a deleted message. This removes that notice.
Why?
This message is incorrect and misleading.
How?
Also check that a ref is set before displaying the notice. This is how the component is displayed in the main edit component.
Testing Instructions
Testing Instructions for Keyboard
As above
Screenshots or screencast
Before:
After:
