Navigation: Remove filters disabling tabs for link and submenu #47593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Will test once #47592 lands. Thank you for considering the need to retain "Settings" as the default tab for these blocks. |
talldan
added
[Type] Task
talldan
approved these changes
Feb 1, 2023
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
I rebased it when testing locally to bring in some other recent changes - removal of the offcanvas editor button and 'settings' as the first tab. There are also now 'dimension' tools for the submenu block.
It's working really well, and feels more consistent than earlier version:
Kapture.2023-02-01.at.14.17.30.mp4
aaronrobertshaw
deleted the
try/removing-tab-filters-for-innner-nav-blocks
branch
Contributor
|
Nice work here @aaronrobertshaw 👏 |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Removes the filters for Navigation Link & Submenu blocks that disable block inspector tab display.
Why?
Once #47592 lands, the settings tab will be the default tab. It was the need to display the settings tab by default when we couldn't programmatically change the tab selection that led to these filters being introduced.
How?
Delete the filters disabling tabs from each block.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-01-31.at.3.50.33.pm.mp4