Skip to content

No need to remove the 'gutenberg_enqueue_global_styles_assets' action #47557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mamaduka merged 1 commit into from
Jan 31, 2023
Merged

No need to remove the 'gutenberg_enqueue_global_styles_assets' action #47557

Mamaduka merged 1 commit into from
Jan 31, 2023

Conversation

@Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Jan 30, 2023

What?

There's no need for those function calls; the gutenberg_enqueue_global_styles_assets method was removed in #41306.

Testing Instructions

CI tests should pass.

@Mamaduka Mamaduka requested a review from scruffian January 30, 2023 13:34
@Mamaduka Mamaduka self-assigned this Jan 30, 2023
@Mamaduka Mamaduka added [Type] Task Issues or PRs that have been broken down into an individual action to take Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Jan 30, 2023
@github-actions
Copy link

github-actions bot commented Jan 30, 2023 •
edited
Loading

Flaky tests detected in 8b9ad5e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4044384098
📝 Reported issues:

@Mamaduka
Copy link
Member Author

Mamaduka commented Jan 31, 2023

I'm going to merge. It's a small clean-up PR.

@Mamaduka Mamaduka merged commit 7b0aef0 into trunk Jan 31, 2023
@Mamaduka Mamaduka deleted the fix/unused-remove-action-calls branch January 31, 2023 05:45
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 31, 2023
@juanmaguitar juanmaguitar added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scruffian scruffian Awaiting requested review from scruffian

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@Mamaduka Mamaduka

Labels

Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Milestone

Gutenberg 15.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Mamaduka @juanmaguitar