Scripts: Simplify scripts registration and remove useless jetpack fix#4754
Merged
youknowriad merged 1 commit intomasterfrom Feb 7, 2018
Merged
Scripts: Simplify scripts registration and remove useless jetpack fix#4754youknowriad merged 1 commit intomasterfrom
youknowriad merged 1 commit intomasterfrom
Conversation
Member
|
Looks like a snapshot test needs to be updated. |
youknowriad
force-pushed
the
refactor/editor-script
branch
2 times, most recently
from
d288ac4 to
f5643e9
Compare
Contributor
Author
|
This should be ready to go |
aduth
previously requested changes
Feb 2, 2018
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I think this line in componentWillUnmount needs to be updated with the prefix?
wp.oldEditor.remove( this.props.id );
aduth
changed the title
youknowriad
force-pushed
the
refactor/editor-script
branch
from
f5643e9 to
87837f0
Compare
2 tasks
youknowriad
force-pushed
the
refactor/editor-script
branch
from
87837f0 to
19149c7
Compare
youknowriad
commented
Feb 7, 2018
| id={ id } | ||
| className={ classnames( className, 'blocks-rich-text__tinymce' ) } | ||
| id={ `editor-${ id }` } | ||
| className="wp-block-freeform blocks-rich-text__tinymce" |
Contributor
Author
There was a problem hiding this comment.
restored the wp-block-freeform className to fix the editor stylesheets. This has broken in a recent PR removing className support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors a little bit the way we enqueue Gutenberg scripts to clarify the dependency we have between the "blocks" module and the classic "editor" script.
It also fixes the classic editor where we were using an
idstarting with a numeric character (this is not valid).It also removes a useless jetpack fix. The right fix has been included in Jetpack in 5.2.2 see #2229
Testing instructions