test: Add separate mobile experiments file #47513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f1351bc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4028093576
|
Member
|
I merged the fix for Playwright e2e test failure #47520. But I see |
The experiments file recently began importing the experimental `off-canvas-editor`. This module eventually imports `@react-spring/web` within its `leaf` module and the `useMovingAnimation` hook. Importing the `@react-spring/web` library results in `react-dom` loading within the React Native testing environment causing test failures. To avoid this scenario, a separate experiments file excluding the `off-canvas-editor` was added for the mobile project. This felt more appropriate than implementing a native version of `off-canvas-editor` or its sibling `list-view` as neither are currently leveraged by the mobile project.
dcalhoun
force-pushed
the
test/add-separate-mobile-experiments-file
branch
from
f1351bc to
10df08d
Compare
Contributor
|
Great idea, it seems like the right approach 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the currently failing mobile unit tests after #47465 merged.
Why?
The experiments file recently began importing the experimental
off-canvas-editor. This module eventually imports@react-spring/webwithin its
leafmodule and theuseMovingAnimationhook. Importingthe
@react-spring/weblibrary results inreact-domloading withinthe React Native testing environment causing test failures.
How?
To avoid this scenario, a separate experiments file excluding the
off-canvas-editorwas added for the mobile project. This felt moreappropriate than implementing a native version of
off-canvas-editororits sibling
list-viewas neither are currently leveraged by the mobileproject.
Testing Instructions
Verify all CI test suites pass.
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a