Update eslint-plugin-jsdoc to support Node 18 and 19
#47490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update package via lerna
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…sfy `require-returns-check`
…require-returns-check`
fabiankaegy
requested review from
adamziel,
draganescu,
juanmaguitar,
kevin940726,
noisysocks,
ryanwelcher,
talldan and
tellthemachines
as code owners
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
fabiankaegy
added
the
[Type] Code Quality
youknowriad
reviewed
Jan 27, 2023
youknowriad
reviewed
Jan 27, 2023
youknowriad
approved these changes
Jan 27, 2023
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
I'd use undefined instead of void but LGTM anyway 👍
…`require-returns-check`
Member
Author
|
@youknowriad Looks like the new push now also is a victim of the new failing mobile test @Mamaduka called out in slack here: https://wordpress.slack.com/archives/C02QB2JS7/p1674831483519249 So I think someone with the correct privileges will need to merge this manually. Thanks again :) |
|
Flaky tests detected in 64e9957. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4025650675
|
This was referenced Jan 31, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the
eslint-plugin-jsdocdependency of theeslint-pluginpackage to version^39.6.9in order to add support for Node version 18 & 19.Closing: #45696
Supersedes: #45697 and #46107
Why?
If you try to install the
@wordpress/eslint-pluginon Node 18 it results in errors due to that package listing a previous version of Node in itsenginesupport.How?
Updating the
eslint-plugin-jsdocdependency of theeslint-pluginpackage to version^39.6.9.Additionally, it was required to update some of the JSDoc definitions in the various packages to meet updated JSDoc rules.
require-returns-checkrule. Therefore explicitundefinedorvoidtypes were added to the return type declarations.Testing Instructions
All CI tests should pass.
Testing Instructions for Keyboard
Not applicable
Screenshots or screencast
Not applicable