Fix react key error with position controls #47367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the key to the array of elements
talldan
added
[Type] Bug
|
Size Change: -4 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jan 24, 2023
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @talldan, sorry for missing this one! 🚀
|
Flaky tests detected in 6859033. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3992512363
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a react
keywarning that occurs intrunk:How?
The key should be defined on an element within an array. It looks like it was accidentally refactored out of the array in #47334
Testing Instructions