Add: Patterns to the template start modal. #47322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Feature] Site Editor
|
Size Change: +99 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fb2b96a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4555586965
|
jorgefilipecosta
force-pushed
the
add/template-modal
branch
from
4933817 to
c7068fa
Compare
jorgefilipecosta
changed the title
jorgefilipecosta
force-pushed
the
add/template-modal
branch
3 times, most recently
from
aace819 to
3e64d6e
Compare
jorgefilipecosta
force-pushed
the
add/other-patterns-to-the-template-start-modal
branch
from
3b06d2b to
25cb9a4
Compare
jorgefilipecosta
force-pushed
the
add/template-modal
branch
2 times, most recently
from
aa4a5fc to
588acd2
Compare
jorgefilipecosta
force-pushed
the
add/template-modal
branch
from
588acd2 to
93fe923
Compare
jorgefilipecosta
force-pushed
the
add/other-patterns-to-the-template-start-modal
branch
from
25cb9a4 to
245fe05
Compare
jorgefilipecosta
force-pushed
the
add/template-modal
branch
from
93fe923 to
7f3133f
Compare
jorgefilipecosta
force-pushed
the
add/other-patterns-to-the-template-start-modal
branch
5 times, most recently
from
bc00a76 to
398d80f
Compare
jorgefilipecosta
force-pushed
the
add/other-patterns-to-the-template-start-modal
branch
2 times, most recently
from
9b33540 to
26893d4
Compare
jorgefilipecosta
force-pushed
the
add/other-patterns-to-the-template-start-modal
branch
2 times, most recently
from
783c094 to
9b4915c
Compare
Contributor
|
This is how it looks. Maybe these previews are way too big, maybe we can show three per row? Anyway, this PR looks good. |
youknowriad
approved these changes
Mar 29, 2023
Contributor
|
Also, maybe a nice follow-up could be to connect to the pattern directory (maybe with a show community patterns button or something) |
jorgefilipecosta
force-pushed
the
add/other-patterns-to-the-template-start-modal
branch
from
9b4915c to
fb2b96a
Compare
jorgefilipecosta
deleted the
add/other-patterns-to-the-template-start-modal
branch
bph
added
the
Needs Dev Note
24 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR glues together #45814 and #46248. This change makes relevant patterns appear has start options of a template instead of just having the fallback and blank as start possibilities.
Testing
I added the following test pattern (temporarily on this branch on lib/blocks.php):
I created a new author-specific template and verified the pattern appears as a start option.
I created a template for all authors and verified the pattern appears as a start option.
I created a 404 template and verified the pattern appears as a start option.