Lodash: Refactor core data away from _.map()
#47189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
aristath,
brookewp,
chad1008,
fabiankaegy,
flootr,
jsnajdr,
ntsekouras,
sgomes and
swissspidy
tyxla
commented
Jan 16, 2023
| path: '/wp/v2/types?context=view', | ||
| } ); | ||
| return map( postTypes, ( postType, name ) => { | ||
| return Object.entries( postTypes ?? {} ).map( ( [ name, postType ] ) => { |
Member
Author
There was a problem hiding this comment.
postTypes could be null, so adding nullish coalescing:
gutenberg/packages/core-data/src/selectors.ts
Line 519 in f558281
| path: '/wp/v2/taxonomies?context=view', | ||
| } ); | ||
| return map( taxonomies, ( taxonomy, name ) => { | ||
| return Object.entries( taxonomies ?? {} ).map( ( [ name, taxonomy ] ) => { |
Member
Author
There was a problem hiding this comment.
taxonomies could be null, so adding nullish coalescing:
gutenberg/packages/core-data/src/selectors.ts
Line 519 in f558281
| return getMergedItemIds( | ||
| state || [], | ||
| map( action.items, key ), | ||
| action.items.map( ( item ) => item[ key ] ), |
Member
Author
There was a problem hiding this comment.
Always an array:
| action.users, | ||
| ( user ) => user.id | ||
| ), | ||
| [ action.queryID ]: action.users.map( ( user ) => user.id ), |
Member
Author
There was a problem hiding this comment.
Always an array:
| export const getUserQueryResults = createSelector( | ||
| ( state: State, queryID: string ): ET.User< 'edit' >[] => { | ||
| const queryResults = state.users.queries[ queryID ]; | ||
| const queryResults = state.users.queries[ queryID ] ?? []; |
Member
Author
There was a problem hiding this comment.
Could be undefined if we don't have such a query, therefore coalescing to an empty array. That handles the nullish scenario for .map() below.
Mamaduka
approved these changes
Jan 16, 2023
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Works as expected.
✅ Verify you're still able to fetch posts when rendering the Latest Posts block in the post editor.
✅ Verify you're still able to fetch categories when rendering the Categories List block in the post editor.
|
Size Change: +21 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.map()from the core data package. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Array.prototype.map()instead, with nullish coalescing when necessary, and withObject.entries()to convert from an object when necessary.Testing Instructions