Refactor WP_Block_Type::render() logic.#4716
Closed
tfrommen wants to merge 4 commits intoWordPress:masterfrom
Closed
Refactor WP_Block_Type::render() logic.#4716tfrommen wants to merge 4 commits intoWordPress:masterfrom
tfrommen wants to merge 4 commits intoWordPress:masterfrom
Conversation
Member
|
This makes sense, and reads a lot nicer. Could we add tests for this logic? |
Hooray to autoloaders. -_-
Member
Author
|
@noisysocks - I just did. ...OK, not "just", but in the end, I did. 😉 |
Member
|
The changes proposed here conflict with those proposed in #4591, namely the removal of |
Member
Author
|
Well, such things happen. If you could add a |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In case of no render callback, the function always returned
''(empty string) for faulty (i.e.,== false)$content. Firstly, the code for doing this was overly complicated, secondly, it didn't make sure there was actually a string being returned, and thirdly, in case of the string'0'there was also the empty string being returned.The proposed code is straightforward, type-safe, and does not include the
'0'error.Checklist: