Notice: refactor to TypeScript #47118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
force-pushed
the
refactor/Notice-typescript
branch
2 times, most recently
from
68198a5 to
eb5fad8
Compare
|
Size Change: +5 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8144310. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4032516688
|
chad1008
force-pushed
the
refactor/Notice-typescript
branch
2 times, most recently
from
673273d to
88a314f
Compare
chad1008
commented
Jan 19, 2023
chad1008
commented
Jan 19, 2023
chad1008
commented
Jan 19, 2023
chad1008
commented
Jan 19, 2023
chad1008
commented
Jan 19, 2023
chad1008
commented
Jan 19, 2023
chad1008
force-pushed
the
refactor/Notice-typescript
branch
from
a2e8e86 to
aa3a9a4
Compare
chad1008
added
[Package] Components
chad1008
force-pushed
the
refactor/Notice-typescript
branch
from
aa3a9a4 to
6a29fb6
Compare
mirka
reviewed
Jan 24, 2023
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Great work here 🎉 Thanks for the attention to detail, plus cleaning up the outdated bits in the readme!
chad1008
force-pushed
the
refactor/Notice-typescript
branch
from
6c50397 to
81dbb3b
Compare
chad1008
force-pushed
the
refactor/Notice-typescript
branch
2 times, most recently
from
9c8815f to
486a948
Compare
mirka
reviewed
Jan 25, 2023
Co-authored-by: Lena Morita <[email protected]>
Co-authored-by: Lena Morita <[email protected]>
Co-authored-by: Marco Ciampini <[email protected]>
Co-authored-by: Marco Ciampini <[email protected]>
Co-authored-by: Marco Ciampini <[email protected]>
This reverts commit 639be12.
chad1008
force-pushed
the
refactor/Notice-typescript
branch
from
8144310 to
d43fe8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor
Noticecomponent to TypeScriptPart of #35744
Why?
The refactor to TypeScript has many benefits (auto-generated docs, static linting and error prevention, better IDE experience). See #35744 for more details
How?
Followed the steps in the TypeScript migration guide
Testing Instructions
Notes
Snackbarto re-use the newNoticetypes, as recommended in Convert theSnackbarcomponent to TypeScript #45472Followups
OnRemoveandOnDismissare confusing props. InNoticethere's really no difference between them. InSnackbarhowever there is a subtle difference in behavior, so it would be good to update the docs of that component to make the distinction more clear.