Simplify editor.canvas by removing hasIframe
#46986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
Flaky tests detected in deb36c6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3878478325
|
kevin940726
force-pushed
the
update/remove-has-iframe
branch
from
bc1fcc2 to
de99acd
Compare
kevin940726
force-pushed
the
update/remove-has-iframe
branch
from
de99acd to
deb36c6
Compare
kevin940726
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
kevin940726
requested review from
talldan
and removed request for
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
juanmaguitar
added
[Type] Build Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Inspired by #40815 (comment). Simplify
editor.canvasby removing thehasIframeoption and checking the existence of the frame automatically.Why?
It's difficult to reason with when the developer has no experience with it before (#45070 (comment)).
How?
We can just return
this.page.frame( 'editor-canvas' ) || this.pageand expect the same result. As per the doc,editor-canvaswill only match thenameof the frame. So it won't match otherdivs with the same class.Testing Instructions
CI should pass.