[Mobile] - Align hook - Add integration tests #46831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
SiobhyB
approved these changes
Jan 3, 2023
Contributor
SiobhyB
left a comment
SiobhyB
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding these! 🙇♀️
I checked through our manual testing suite and saw we have manual tests to check alignment for the following blocks: Buttons, Media & Text, Verse, File, and Audio. I don't think these need to be added to this PR, but I wondered whether it may be worthwhile opening a separate GitHub issue to add them eventually. We could then remove the manual tests. Wdyt?
Member
Author
|
Thank you for reviewing! 🚀
I think we could remove some, but I think we should keep at least one test that tests a few blocks to double-check if elements align correctly (visually). |
geriux
removed
the
Mobile App - Automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Closes wordpress-mobile/gutenberg-mobile#3792
What?
This PR adds some integration tests for block alignment options on mobile.
Why?
We've had regressions before since we share some logic related to block alignments support.
How?
By adding some integration tests which test a media block, a text block, and a group block.
Testing Instructions
npm run native test packages/block-editor/src/hooks/test/align.native.jsTesting Instructions for Keyboard
N/A
Screenshots or screencast
N/A