Add test for experimental/block-editor-settings-mobile endpoint #46816
Conversation
geriux
added
the
[Type] Automated Testing
|
Hey @oandregal 👋 I added you as a reviewer for this PR, not sure if you could check it out (no rush), if not, could you suggest who could I ping for it? Thank you! |
|
Seeing that it's a bit more involved than usual, I've tagged @anton-vlasenko who has more experience than I do in this area. |
fluiddot
left a comment
fluiddot
left a comment
There was a problem hiding this comment.
The unit test looks good to me ✅. However, since it's the first PHP unit test I review, I'd like to defer the approval to someone else.
|
Hey @anton-vlasenko 👋 let me know if you could take a look or let us know who else could check it out, thank you! |
|
Hey @oandregal 👋 I was wondering if perhaps you might know someone else who could check this PR? Any help to move this forward would be appreciated, thank you! |
oandregal
left a comment
oandregal
left a comment
There was a problem hiding this comment.
The code seems fine to me, it doesn't break anything, and it's not supposed to be backported given the mobile REST endpoint is still experimental. Let's ship it as it provides value for you. People can always do a review post-merge and adjust as necessary.
juanmaguitar
added
[Type] Build Tooling
|
@geriux @oandregal Sorry for not replying. My bad. |
What?
This test adds a basic test for the Block editor settings endpoint used from the mobile apps.
Why?
Sometimes there are changes that affect this endpoint and it's more recently breaking often, this implies different teams working on fixes and making patch releases.
How?
By adding a basic test that checks the endpoint exists and that it returns the expected keys in the response. I didn't check the content of those for now.
Testing Instructions
Unit Tests / PHPshould pass.npm run test:phplocally.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A