[Mobile] Update E2E tests by removing some in favor of integration tests #46583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 15, 2022 14:37
…the previous version of the block and new integration tests were added to support List Block V2
geriux
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
…t will be run in a different job (device-tests-canary)
geriux
removed
the
Mobile App - Automation
geriux
deleted the
rnmobile/remove-some-e2e-test-with-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR:
What?
This PR focuses on removing unnecessary E2E tests that could be done as integration tests, it also avoids running the
canarytests when running thedevice-teststask, since thecanarytests have their owndevice-tests-canarythis avoids runningcanarytests twice when running the full suite.Why?
To improve time while running the E2E tests as well as reducing unnecessary tests that could be handled as integration tests, like checking if the block renders correctly. We already have the
initial HTMLtest that renders all blocks.How?
V1and new integration tests were added to support List BlockV2(see)canarytests indevice-teststask (see). Since they have their owndevice-tests-canarytask.Testing Instructions
CI checks in Gutenberg Mobile should pass correctly.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A