[RNMobile] Add capabilities to force only Core blocks and control Support section #46215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
2 tasks
fluiddot
force-pushed
the
rnmobile/disable-jp-editor-features
branch
2 times, most recently
from
c0efb67 to
2e2e4c5
Compare
fluiddot
commented
Dec 2, 2022
Comment on lines
+154
to
+155
| __( 'We are working hard to add more blocks with each release.' ), | ||
| blockName |
Contributor
Author
There was a problem hiding this comment.
Passing the block name will allow overriding the details depending on the block.
fluiddot
force-pushed
the
rnmobile/disable-jp-editor-features
branch
2 times, most recently
from
3529605 to
56e36fb
Compare
derekblank
approved these changes
Dec 22, 2022
Member
derekblank
left a comment
derekblank
left a comment
There was a problem hiding this comment.
LGTM. 🚀 Approved via wordpress-mobile/gutenberg-mobile#5293 (review)
fluiddot
force-pushed
the
rnmobile/disable-jp-editor-features
branch
from
b179763 to
5edf972
Compare
fluiddot
force-pushed
the
rnmobile/disable-jp-editor-features
branch
from
5edf972 to
c09fa71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onlyCoreBlockscapability is enabled wordpress-mobile/gutenberg-mobile#5293What?
Add a capability to control when to display the support section within the Editor help screen. In addition to this, another capability has been added to force registering only core blocks, although this logic will be applied in a Gutenberg Mobile PR.
Why?
These capabilities will allow us to have more-grained control over features available between WordPress and the Jetpack app.
How?
The following capabilities have been added to the bridge code of both platforms Android and iOS:
supportSectiononlyCoreBlocksTesting Instructions
This change should be tested via the Gutenberg Mobile PR, follow the testing instructions outlined there.
Screenshots or screencast
N/A