Lodash: Refactor block library away from _.filter()
#46114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
aristath,
brookewp,
chad1008,
fabiankaegy,
flootr,
jsnajdr,
ntsekouras,
sgomes and
swissspidy
tyxla
commented
Nov 28, 2022
Member
Author
There was a problem hiding this comment.
attributes is always an array, and is being used as an array already a few lines above.
Member
Author
There was a problem hiding this comment.
images is being used as an array throughout the entire component already.
Member
Author
There was a problem hiding this comment.
Defaults to an array:
Member
Author
There was a problem hiding this comment.
Defaults to an array:
Member
Author
There was a problem hiding this comment.
Defaults to an array:
Member
Author
There was a problem hiding this comment.
Although very edge case-y, taxonomies could be null:
|
Size Change: -20 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
refactor/block-library-lodash-filter
branch
from
ba986c8 to
7c8e088
Compare
ntsekouras
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.filter()from theblock-librarypackage. There are just a few simple usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Array.prototype.filter()with some additional checks where necessary.Testing Instructions