The prelint:php script doesn't work as expected when new dev dependencies get added to composer.json
#45468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Dec 28, 2022
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Seems like a good change to me 👍
anton-vlasenko
force-pushed
the
fix/prelint-command-doesnt-work-as-expected
branch
from
5e2747c to
3b0665e
Compare
Contributor
Author
|
Thanks for the review, @jorgefilipecosta! |
anton-vlasenko
deleted the
fix/prelint-command-doesnt-work-as-expected
branch
juanmaguitar
added
the
[Type] Build Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This scpirt modifies the
prelint:phpnpmscript to ensure that dev dependencies get installed.Fixes #45313
Why?
If a user runs the
npm run prelint:phpcommand for the first time, it works as expected, as there is nocomposer.lockfile. All the packages get installed.If, after some time, the contents of the composer.json file get modified, and the user tries to run the command again, these new packages will not be installed.
In such case,
composer.lockhas priority overcomposer.json, and the latter is ignored.How?
The
composer updatecommand should be used instead ofcomposer installto ensure that the packages get updated according tocomposer.json.Testing Instructions
wp-env.npm run prelint:php.npm run lint:php.