-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Navigation block e2e tests: default to a list of pages if there are no menus #45070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: +960 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
8932457 to
93d95f1
Compare
|
Looks like this test needs work since the page list block has changed :D |
93d95f1 to
9027a6c
Compare
adcd436 to
6b4a65c
Compare
getdave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving these forward 🎉
I noticed that we're not actually checking that Pages are rendered because we don't wait for the request to complete. Hopefully that's ok as the Page List tests should be responsible for that I guess.
|
@kevin940726 I've tried to wait on specific network requests. But every time I try running these tests the I looked at the artifacts provided by the test runner and no matter what I do the Page List block only becomes visible in the editor after the I'm a bit stuck at this point. Any help or advice would be much appreciated. |
|
Flaky tests detected in 491a297. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3868144494
|
Thanks for the ping! I believe it's because we didn't use I hope it's okay for me to push the change directly on this branch :). |
e93488f to
491a297
Compare
|
Ok I'm happy with the structure and intent of this test. Requesting final review(s). |
draganescu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! 🚢 it!
What?
This is part of the effort to re work all the navigation block e2e tests and migration to playwright. This is one of the user stories described in #45199
Why?
The navigation e2e tests were really flaky and bottlenecking the github actions. We are rethinking them so they make more sense and are more usable and maintainable.
Testing Instructions
Run
npm run test:e2e:playwright -- editor/blocks/navigation.spec.jsCo-authored-by: Dave Smith [email protected]