-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Post excerpt: add text alignment to the placeholder #45003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Contributor
|
Seems conceptually fine to me 👍 |
Mamaduka
approved these changes
Jan 30, 2023
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Post Excerpt
Affects the Post Excerpt Block
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds text alignment controls to the block toolbar of the post excerpt placeholder.
Closes #44324
Why?
The placeholder should have the same styling options as the regular block.
How?
Adds the alignment toolbar to the placeholder.
Testing Instructions
In the site editor, open the template for single posts.
Add an excerpt block to the template (or convert an existing post content block to a post excerpt).
Confirm that the placeholder is showing and that you can align the text to the left/center/right using the toolbar.
Save and view a post on the front. Confirm that the text aligns to the left/center/right correctly.
Screenshots or screencast