Hide the done button of the Global Style palette editor when there aren't colors to edit #44372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierarce
changed the title
|
Size Change: +3 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
jasmussen
added
[Type] Enhancement
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the behavior of the done button in the palette editor.
Currently, if you remove all the items from the color palette, the done button stays visible, giving the impression that you need to click it to finish the edition (which is not true)
Before
before.mov
After
after.mov
How to test this PR
The done button should disappear.