Scripts: Use start without watcher using --no-watch#44237
Merged
gziolo merged 1 commit intoWordPress:trunkfrom Feb 2, 2023
Merged
Scripts: Use start without watcher using --no-watch#44237gziolo merged 1 commit intoWordPress:trunkfrom
gziolo merged 1 commit intoWordPress:trunkfrom
Conversation
kkmuffme
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
ryanwelcher
as code owners
gziolo
added
[Tool] WP Scripts
gziolo
reviewed
Sep 17, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Thank you for opening this PR. The change proposed makes sense 👍🏻
There are some formatting issues and running npm run format will fix them.
kkmuffme
force-pushed
the
start-no-watch-option
branch
from
50e7d48 to
4cc05a3
Compare
kkmuffme
requested review from
gziolo
and removed request for
ajitbohra,
nerrad,
ntwb and
ryanwelcher
gziolo
changed the title
gziolo
changed the title
gziolo
approved these changes
Sep 21, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I added an entry in the Changelog file. I need to test it locally before merging to trunk.
gziolo
requested changes
Sep 21, 2022
ryanwelcher
added
[Type] Enhancement
kkmuffme
force-pushed
the
start-no-watch-option
branch
from
2076d6a to
40d45c7
Compare
Contributor
Author
|
Sorry for the delay, fixed now. It's ready to be merged now |
Member
|
Thank you for addressing my feedback. I will land it as soon as I have a chance to test it again. |
Contributor
Author
|
@gziolo could you please check and merge this now? |
gziolo
approved these changes
Feb 2, 2023
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
This tests well with the changes applied. Thank you so much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Sometimes there's a use case, where we don't want to use "npm start" with the watcher.
Why?
"npm start" directly followed by Ctrl+C, or certain CI environments that want to create unminified JS for analysis without changing the config,...
How?
Testing Instructions
any gutenberg, isntead of "npm start" run "npm start -- --no-watch", which will create the unminified/dev JS without starting the watcher.