Prevent flipping the border style when creating RTL stylesheets #44170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
Internationalization (i18n)
|
Size Change: -1 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
Contributor
|
@andrewserong @ramonjd @aaronrobertshaw Can you help get this PR to the finish line, this is still a valid bug fix. |
youknowriad
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
force-pushed
the
fix/border-style-rtl
branch
from
f817e1d to
b067f56
Compare
Member
|
Here's what I'm seeing in the block editor
Before the left and right borders were not showing in the editor. After they are there! No regression in the frontend as far as I can see, also checked LTR languages. LGTM |
ramonjd
approved these changes
Dec 8, 2025
Member
|
Oh yeah, and the borders aren't "flipped" between RTL and LTR as far as I can see too 👍🏻 |
Member
|
I'll merge this tomorrow if there are no objections |
|
Flaky tests detected in b067f56. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20013730761
|
Contributor
|
Thanks for following up @ramonjd I appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44169 by not flipping the border style when creating the RTL stylesheets. On trunk, adding a border to a block on an RTL site will apply the border style to the wrong side, causing a black border on the wrong side, and no border on the correct side. #44169 has some screenshots.
The issue seems to be that the
rtlcssprocess flips the properties, so thatbecomes
The right border no longer has a default style, so it doesn't show up, and the left border now has a style so it also inherits a default width and color.
Testing Instructions