navigation block: fix empty site-log li element in the dom
#44049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty check is added if `core/site-logo` is non-empty then add a `li` element in the dom or else it will continue rest of the statements. Fixes: #43470
amustaque97
force-pushed
the
fix-43470-site-logo-empty-navigation-block
branch
from
23383a2 to
28b539a
Compare
amustaque97
added
Needs Testing
carolinan
approved these changes
Sep 12, 2022
Contributor
carolinan
left a comment
carolinan
left a comment
There was a problem hiding this comment.
This is working well in my test, thank you.
ockham
reviewed
Sep 12, 2022
ockham
approved these changes
Sep 12, 2022
Contributor
ockham
left a comment
ockham
left a comment
There was a problem hiding this comment.
Thanks @amustaque97! This LGTM.
I had a minor suggestion, but it's not crucial. Feel free to apply or ignore 😊
Co-authored-by: Bernie Reiter <[email protected]>
cbravobernal
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a condition to verify that the site-logo is not null.
Why?
Don't create a
lielement in the dom when the site-logo is empty. If there is an emptylitag, it will add some extra space on the frontend.How?
An empty condition is added if
core/site-logois non-empty then add alielement in the dom or else it will continue the rest of the statements.Testing Instructions
<li></li>Fixes: #43470