Make inline toolbar navigable by arrow keys#43645
Merged
Merged
Conversation
Contributor
Author
|
I will follow up on these failing tests next week. |
alexstine
added
[Focus] Accessibility (a11y)
alexstine
reviewed
Sep 11, 2022
Contributor
alexstine
left a comment
alexstine
left a comment
There was a problem hiding this comment.
@apmatthews Thanks for the improvements. Could you please refresh the branch and maybe tests will pass?
Contributor
|
@apmatthews Maybe try one more refresh? Lots seems to be changing around this at the moment. |
Contributor
Author
|
@alexstine I've just kicked it off once more. If tests do not pass this time, I'll try and find some time this week to pull it down and debug whatever is failing. The failures don't seem related at first glance, but who knows 🤷🏻. Thanks for bumping it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allows users to navigate the inline toolbar using arrow keys rather than tabs.
Why?
Users can navigate the block toolbar using arrow keys. The inline toolbar should behave the same way for consistency.
Resolves #43564
How?
Adds the
NavigableToolbarcomponent to the inline toolbar.Testing Instructions