Skip to content

Tag cloud: add spacing block supports #43367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ramonjd merged 1 commit into from
Aug 18, 2022
Merged

Tag cloud: add spacing block supports #43367

ramonjd merged 1 commit into from
Aug 18, 2022

Conversation

@ramonjd
Copy link
Member

@ramonjd ramonjd commented Aug 18, 2022

Related:

What?

Enabling spacing support for the Tag cloud block

Why?

To create consistency across blocks.

How?

Adding the relevant block supports in block.json

Testing Instructions

  1. Create a few posts, add a few tags.
  2. Load the block editor and add a Tag cloud block.
  3. Confirm that the dimensions control panel is there
  4. Add margin and padding.
  5. Save and confirm the styles appear on the frontend.
  6. Test the new support works for the block via theme.json and global styles. See example JSON below.
	"styles": {
		"blocks": {
			"core/tag-cloud": {
				"spacing": {
					"padding": "122px",
					"margin": "22px"
				}
			}
		}
	}

Screen Shot 2022-08-18 at 8 05 21 pm

@ramonjd ramonjd added [Type] Enhancement A suggestion for improvement. [Block] Tag Cloud Affects the Tag Cloud Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 18, 2022
@ramonjd ramonjd self-assigned this Aug 18, 2022
@ramonjd ramonjd force-pushed the add/tag-cloud-spacing-support branch from 42a690b to f3135f7 Compare August 18, 2022 10:12
@ramonjd ramonjd mentioned this pull request Aug 18, 2022
Open
@apeatling apeatling assigned apeatling and unassigned apeatling Aug 18, 2022
@apeatling apeatling self-requested a review August 18, 2022 17:47
apeatling
apeatling approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@apeatling apeatling left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirm that the dimensions control panel is there
✅ Add margin and padding.
✅ Save and confirm the styles appear on the frontend.
✅ Test the new support works for the block via theme.json and global styles. See example JSON below.

@ramonjd ramonjd merged commit 1ec3395 into trunk Aug 18, 2022
@ramonjd ramonjd deleted the add/tag-cloud-spacing-support branch August 18, 2022 22:33
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
@t-hamano t-hamano mentioned this pull request Sep 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeatling apeatling apeatling approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@ramonjd ramonjd

Labels

[Block] Tag Cloud Affects the Tag Cloud Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ramonjd @apeatling @femkreations