-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Base Styles: Apply long-content-fade gradient from transparent to color
#42401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base Styles: Apply long-content-fade gradient from transparent to color
#42401
Conversation
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable fix. Tested it an it works, that rbga implementation seems outdated and transparent is supported by most modern browsers. ✅
Probably should let the gutenberg team take a look before merging
cbravobernal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What?
The
long-content-fademixin expects the$colorargument to be in RGB format, that is because it needs a way to get the zero-opacity version of that color.This was done by interpolating the chosen
$color(say#fff) with argbacall, likergba( $color, 0 ).Why?
Though this works fine with raw RGB colors, it won't work with other color formats, nor with CSS variables.
How?
I'm moving from
rgba( $color, 0 )totransparent, which is essentially the same thing.It shouldn't make any difference in the front-end, but it will improve the way we write CSS since now we're going to be able to pass other formats of colors, even variables, to that mixin.
transparentis well supported, so there's no need to use 5-year-old technology anymore.Testing Instructions
Apply this branch to Calypso;
Still in Calypso: run
yarn workspace @automattic/search run storybook. It should open Storybook. Go to theWith Different Colorstory, type something in the search input and you should see something like that:Notice how the fading effect at the edge of the search input is gone. This is because I'm using a CSS variable to style the
<Search />component.Now, check out this branch in local Gutenberg, run:
So you have this PR's version of
base-stylesloaded in Calypso. I'm not sure why, butyarn linkdidn't work for me. When you refresh Storybook, you should see:Notice how the edges are fading out and it indicates that there are more characters hidden.