Skip to content

Compare against default category in the settings instead of hardcoded slug #41956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mamaduka merged 3 commits into from
Jun 28, 2022
Merged

Compare against default category in the settings instead of hardcoded slug #41956

Mamaduka merged 3 commits into from
Jun 28, 2022

Conversation

@grappler
Copy link
Member

@grappler grappler commented Jun 25, 2022

What?

Get default category based of setting instead of hardcoded slug.

Why?

Fixes #41955

How?

Instead of using the hardcoded slug, the ID for the default category is fetched from the settings.

Testing Instructions

Test 1

  1. Create a new post and publish
  2. The suggestion for categories should show in the pre-publish panel

Test 2

  1. Create a new category
  2. Change the default category to the newly created category in the writing setting wp-admin/options-writing.php
  3. Create a new post with the new category
  4. Publish post and see the suggestion for categories in the pre-publish panel

amustaque97
amustaque97 reviewed Jun 26, 2022
View reviewed changes
Copy link
Member

@amustaque97 amustaque97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it works for me. Thank you for your contribution 👏🏻

I had a glimpse at the static check, not sure why it failed. Though it looks unrelated to your changes.

@amustaque97 amustaque97 requested a review from youknowriad June 26, 2022 20:33
@Mamaduka Mamaduka requested review from Mamaduka and removed request for youknowriad June 27, 2022 18:05
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Jun 27, 2022
Mamaduka
Mamaduka approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thanks, @grappler!

@Mamaduka Mamaduka merged commit 024b339 into WordPress:trunk Jun 28, 2022
@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 28, 2022
@grappler grappler deleted the suggest-adding-category branch June 28, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amustaque97 amustaque97 amustaque97 left review comments

@Mamaduka Mamaduka Mamaduka approved these changes

Assignees

No one assigned

Labels

General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 13.6

Development

Successfully merging this pull request may close these issues.

Suggest picking a category on the pre-publish panel, only works for English

3 participants

@grappler @Mamaduka @amustaque97