Webfonts API: Document fontFace and it’s values in theme.json schema
#41844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grappler
changed the title
theme.json schematheme.json schema
grappler
changed the title
theme.json schemafontFace and it’s values in theme.json schema
Closed
5 tasks
grappler
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
fabiankaegy
approved these changes
Jun 22, 2022
Member
fabiankaegy
left a comment
fabiankaegy
left a comment
There was a problem hiding this comment.
This is a great addition :) Added one comment. But that can also happen in a follow up 👍
Member
Author
|
It would be great if this could be backported to wp/6.0 too. Happy to create a second PR for that. |
Member
|
@adamziel, I think this needs to be backported so that the schema URL is correctly resolved. It's not a blocker for a minor release. |
Mamaduka
added
the
Backport to WP Minor Release
adamziel
pushed a commit
that referenced
this pull request
Jun 30, 2022
…ema (#41844) * Document fontFace and it’s values in theme.json schema * npm run docs:build * Fully document all options * required & additionalProperties placed incorrectly * Missing properties and small fixes * Remove extra space * Font-weight is not required * Font weight can be either a string or an integer
Contributor
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 6a79add |
adamziel
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Document the
fontFaceproperties that we introduced in WordPress 6.0 as part of the WebFonts API.Why?
Because there is no documentation.
How?
By including the basic technical documentation to the
theme.jsonschema.Testing Instructions
Create a
theme.jsonand paste the following in the code. Currently, it says that thefontFaceis not allowed. Replacehttps://schemas.wp.org/trunk/theme.jsonwithhttps://raw.githubusercontent.com/grappler/gutenberg/schema-fontFace/schemas/json/theme.jsonto test changes.`theme.json` code
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 2, "settings": { "typography": { "fontFamilies": [ { "fontFamily": "\"Source Serif Pro\", serif", "name": "Source Serif Pro", "slug": "source-serif-pro" }, { "fontFamily": "\"Inter\", sans-serif", "name": "Inter", "slug": "inter", "fontFace": [ { "fontFamily": "Inter", "fontWeight": "200 900", "fontStyle": "normal", "fontStretch": "normal", "src": [ "file:./assets/fonts/inter/Inter.ttf" ] } ] } ] } } }Screenshots