Handle no variation case in the block transform menu#41328
Merged
Conversation
youknowriad
added
[Type] Bug
Contributor
Author
|
I'll see if I can add an e2e test that would catch this in the future. |
Mamaduka
reviewed
May 25, 2022
|
Size Change: +5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 25, 2022
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
I'm still not able to reproduce the issue. But based on the code and the fact that variations can be undefined, this guard clause makes sense.
Contributor
Author
|
I'm failing to put the right conditions in the e2e test to make it fail :) |
mcsf
reviewed
May 25, 2022
andrewserong
approved these changes
May 26, 2022
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This change LGTM, but like some of the others, I wasn't able to reproduce the error.
It looks like a good defensive conditional to add, though, as I missed that in the useSelect call variations can be returned as a falsy value.
Thanks for putting up the fix!
youknowriad
added a commit
that referenced
this pull request
May 26, 2022
youknowriad
added a commit
that referenced
this pull request
Jun 3, 2022
adamziel
pushed a commit
that referenced
this pull request
Jun 21, 2022
Contributor
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 0eaf63d |
adamziel
removed
the
Backport to WP Minor Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #41321
What?
If you insert the classic block while the sidebar is open, you'll see the editor break.
Testing Instructions
1- Open the editor sidebar
2- Insert a classic block
3- The editor shouldn't break.