Remove forced focus of InputControl on mousedown
#41118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -39 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
ciampo
reviewed
May 19, 2022
| } ); | ||
|
|
||
| describe( 'Ensurance of focus for number inputs', () => { | ||
| it( 'should focus its input on mousedown events', () => { |
Contributor
There was a problem hiding this comment.
Maybe a silly question, but — shouldn't we keep this unit test?
Technically the code in this PR is not necessary, given change in #40518 — and therefore I would keep the unit tests as they are, and expect the to still pass.
Contributor
Author
There was a problem hiding this comment.
The test was added along with the code in #29305. I expected such a test to never fail #29305 (comment) because inputs are focused on mousedown (except Firefox when mousedown is on the spin buttons). Apparently that focus is not synchronous. So without the code this test fails.
Contributor
There was a problem hiding this comment.
I see, thank you for the context!
I tried using user-event and it seems to fix the issue:
describe( 'Ensurance of focus for number inputs', () => {
it( 'should focus its input on mousedown events', async () => {
const user = userEvent.setup( {
advanceTimers: jest.advanceTimersByTime,
} );
const spy = jest.fn();
render( <InputControl type="number" onFocus={ spy } /> );
const input = getInput();
await user.click( input );
expect( spy ).toHaveBeenCalledTimes( 1 );
} );
} );
Contributor
Author
There was a problem hiding this comment.
Pardon me for dropping this. I still think the test should be removed. If we "fix" it as suggested then it's testing that focus happens when clicked and that's merely testing UA behavior.
stokesman
force-pushed
the
fix/input-field-reset-behavior
branch
from
5150ade to
3ac6020
Compare
Member
|
Hi, @stokesman I'm doing old PR cleanup, can we close this draft as "stale"? |
stokesman
force-pushed
the
update/remove-forced-focus-input-control
branch
2 times, most recently
from
b3780ab to
868add0
Compare
stokesman
added
the
[Type] Code Quality
Contributor
Author
Thanks for asking. I'd like if this can still land so I rebased it but it's not by any means necessary. |
|
Flaky tests detected in 868add0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/15288377263
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
force-pushed
the
update/remove-forced-focus-input-control
branch
from
868add0 to
5cb5cb8
Compare
ciampo
approved these changes
Jun 3, 2025
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
🚀 LGTM
- ✅ Code changes look good
- ✅ The unit test being removed would pass anyway
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: stokesman <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes code obviated by #40518.
Why?
It is no longer needed as it was only required (for Firefox) when
InputControlhad to be focused in order to update itself.How?
Removes the code and a unit test that was specific to it.
Testing Instructions
NumberControlcan be clicked to increment/decrement without causing the input to gain focus.InputControlstill behave as expected.Screen Recording
input-control-no-forced-focus.mp4