ListView: fix e2e flakiness#39742
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom Mar 25, 2022
Merged
Conversation
See: WordPress#39506 See also: 39641
delowardev
changed the title
Mamaduka
approved these changes
Mar 25, 2022
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Changes look good to me. Thank you, @delowardev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
ListView e2e test is being flagged as flaky
Why?
Fixes: #39506
Fixes: #39641
How?
Wait for the
expectpromise to be resolved.Testing Instructions
Run
packages/e2e-tests/specs/editor/various/list-view.test.jsa few times, you will see it fails sometimes.Screenshots or screencast