Flex Layout: Fix visibility control of allowOrientation #39532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
apeatling
approved these changes
Mar 17, 2022
Contributor
apeatling
left a comment
apeatling
left a comment
There was a problem hiding this comment.
✅ I tested this as per the instructions and can confirm that setting the allowOrientation flag in __experimentalLayout to false results in the UI for orientation being hidden:
Contributor
Author
|
Thanks for the review! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the flag that we can set in
block.jsonto control the visibility of the orientation control in Flex layouts.Why?
It looks like previously the code was trying to grab the flag from the layout object instead of the block supports object, where the flag is set.
How?
Similar to the other controls, grab the setting from the
layoutBlockSupportobject.Testing Instructions
In
packages/block-library/src/buttons/block.jsontry adding theallowOrientationflag to__experimentalLayoutand set it tofalselike the following:Before this PR, it would have no effect. After this PR, it should hide the control. Also check that switching it to
truereveals it again.Screenshots or screencast