Skip to content

Conversation

@amustaque97
Copy link
Member

@amustaque97 amustaque97 commented Feb 23, 2022

Description

As mentioned in the issue #35377, I have implemented both the scenarios
and tested them in interactive mode. Test cases are passing.

Closes #35377.

  • it disables the publish button when a post is locked
  • it disables the save shortcut when a post is locked

Testing Instructions

  1. Checkout this PR
  2. Run npm run test-e2e

To explore more options on how to run test cases, follow the given link instructions:
https://github.com/WordPress/gutenberg/blob/8c3ca76906ddb61f1e7639442815e70fa068cc85/docs/contributors/code/testing-overview.md#end-to-end-testing

Screenshots

Screenshot 2022-02-23 at 7 15 23 PM

Types of changes

Code quality/testing

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

As mentioned in the issue WordPress#35377, I have implemented both the scenarios
and tested them in interactive mode. It is passing.
@amustaque97 amustaque97 self-assigned this Feb 23, 2022
@amustaque97 amustaque97 added [Feature] Saving Related to saving functionality [Package] E2E Tests /packages/e2e-tests [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Feb 23, 2022
@Mamaduka Mamaduka requested a review from talldan February 23, 2022 14:33
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @amustaque97. This looks good.

Let's wait for checks to be green again and be sure my suggestions didn't mess up anything 😅

@Mamaduka Mamaduka merged commit 2cc26fd into WordPress:trunk Feb 24, 2022
@github-actions github-actions bot added this to the Gutenberg 12.8 milestone Feb 24, 2022
@amustaque97 amustaque97 deleted the test/35377-e2e-post-locking branch February 24, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Saving Related to saving functionality [Package] E2E Tests /packages/e2e-tests [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add end to end tests for post locking

2 participants