WP Env: Fix infinite redirection with custom site URL #38352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
noahtallen
approved these changes
Feb 1, 2022
Member
noahtallen
left a comment
noahtallen
left a comment
There was a problem hiding this comment.
This change makes sense to me, thanks! I think the intention was to allow WP_SITEURL, etc., to control the domain, so this fix makes that work better. 👍
Member
Author
|
@noahtallen Thank you for the review! I went ahead and merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose you want to use
@wordpress/envwith a custom URL other thanlocalhost.When you set
WP_SITEURLin.wp-env.json: config.configto something (e.g.mysite.local) and you add some rules to/etc/hosts, and then you try to access the site atmysite.local, an infinite redirection bug happens becauseget_option( 'siteurl' )will be incorrect due to howwp-envinstalls wordpress.This is a fix for that bug so that you can have custom URLs.
@noahtallen got time to review? Also please read Note below.
Note
I'm adding this fix because I needed it for my personal use, and I thought it might be useful to other people relying on
@wordpress/env. I intend to make these PRs as I add features / fixes... At least until my personal wp-env fork doesn't diverge so far that porting changes here becomes too difficult.If you're not interested in this or don't have time to review, that's completely okay. Feel free to close the PR.