[RNMobile] Add custom image support to block style previews #37066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Register new block * Enable new block capability
* Register new block * Enable new block capability
…ss/gutenberg into rnmobile/add/tiled-gallery-block
* Register new block * Enable new block capability
…ss/gutenberg into rnmobile/add/tiled-gallery-block
These files were committed by mistake, after they were automatically generated. This commit reverts their addition.
guarani
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
2 tasks
Contributor
Author
|
Closing because this isn't being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing
BlockStylescomponent provides UI to allow the user to switch between a block's styles. On mobile, it lacked support for different preview image for each style. Instead, it only allowed a single image to be used for all styles.It's important to note that on native mobile,
BlockStylesis only used in the Image block. There it was used for the Default and Rounded styles. A single image is used for both styles, and SCSS is used to make the latter style preview appear rounded.The
BlockStylescomponent has a completely different implementation on the web where each preview is a live rendering of that style using aniframe.I think making this change to only native mobile – not web – is warranted since the
BlockStylescomponent differs greatly on the web.How has this been tested?
TO-DO
Screenshots
TO-DO
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).