Move PluginBlockSettingsMenuItem to BlockEditor package #36691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves PluginBlockSettingsMenuItem to the block-editor package as this SlotFill can also be used on Widget scren.
HardeepAsrani
requested review from
ajitbohra,
ellatrix and
mkaz
as code owners
gziolo
added
the
[Feature] Extensibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit moves PluginBlockSettingsMenuItem to the block-editor package as this SlotFill can also be used on Widget screen to avoid edit-post breaking the Widget screen.
Fixes #36690
How has this been tested?
The change works. Didn't know if we add deprecation function now or what's the process so more info with that will be appreciated.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).