wp-env: Add install-path command. #35638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribaricplusplus
added
[Tool] Env
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
Contributor
|
This tested well for me @ribaricplusplus. It would be good to get an entry added to the Readme as part of this PR, eg. after the |
Member
Author
|
Added |
noahtallen
reviewed
Jan 5, 2022
Member
noahtallen
left a comment
noahtallen
left a comment
There was a problem hiding this comment.
Looks pretty good to me! Just have one thought for an addition.
| * Logs the path to where wp-env files are installed. | ||
| */ | ||
| module.exports = async function installPath() { | ||
| const { workDirectoryPath } = await readConfig( |
Member
There was a problem hiding this comment.
I think we should check if this path exists before outputting it:
~/source/gutenberg
$ ./packages/env/bin/wp-env install-path
/home/nt/.wp-env/2ccfc3290b190367751be3c7bce4c188
~/source/gutenberg wp-env/install-path
$ cd ..
~/source # wp-env is not used here
$ ./gutenberg/packages/env/bin/wp-env install-path
/home/nt/.wp-env/e7bffa65797a36b9089db69d81c0879dreadConfig (if I recall) just generates a config based on everything available. But nothing exists until wp-env start has been executed. I think it might be helpful to output an error in the case that the work directory path doesn't exist yet, rather than just showing what it would be.
Member
Author
|
Good point! I made the update that checks that files exist:
|
glendaviesnz
approved these changes
Jan 11, 2022
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
Thanks for adding the readme entry, and the additional path check is testing well for me also 🎉
noahtallen
reviewed
Jan 17, 2022
| */ | ||
| module.exports = async function installPath() { | ||
| const configPath = path.resolve( '.wp-env.json' ); | ||
| if ( ! fs.existsSync( configPath ) ) { |
Member
There was a problem hiding this comment.
Sorry for going back and forth on this so much! It is possible to run wp-env without the JSON configuration file (iirc), so I might remove this portion of the check. Otherwise this looks great 👍
Member
Author
There was a problem hiding this comment.
Ah, slipped my mind! You're right.
Member
Author
There was a problem hiding this comment.
I will remove it today or tomorrow... Or you can do it if you feel ilke it :)
noahtallen
force-pushed
the
wp-env/install-path
branch
from
176028f to
8945640
Compare
Member
Thanks! I did a pass, and ran into an issue since
|
noahtallen
approved these changes
Jan 17, 2022
bph
added
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have many
wp-envinstances on my machine for various projects I'm working on. When I go to thewp-envfolder where all these instances are installed, I'm met with a bunch of hashes and I can't figure out which project is installed where.This PR adds an
install-pathcommand that logs to the console where this particular instance's files are.Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).