FIX - Cannot type in the Link Input dialog when in a paragraph#3468
Merged
youknowriad merged 3 commits intomasterfrom Nov 14, 2017
Merged
FIX - Cannot type in the Link Input dialog when in a paragraph#3468youknowriad merged 3 commits intomasterfrom
youknowriad merged 3 commits intomasterfrom
Conversation
BoardJames
added
the
[Type] Bug
Codecov Report
@@ Coverage Diff @@
## master #3468 +/- ##
==========================================
+ Coverage 33.83% 33.92% +0.08%
==========================================
Files 253 253
Lines 6741 6745 +4
Branches 1223 1225 +2
==========================================
+ Hits 2281 2288 +7
+ Misses 3761 3759 -2
+ Partials 699 698 -1
Continue to review full report at Codecov.
|
youknowriad
approved these changes
Nov 14, 2017
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Good catch. Nice fix and test 👍
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #3466
fixes #3467
How Has This Been Tested?
Manual, unit tests
Screenshots (jpeg or gifs if applicable):
Types of changes
Bug fix
Checklist: