-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Register new block #34472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register new block #34472
Conversation
|
@guarani, I followed the steps for both Android and iOS but haven't been able to view this block in the demo app for either. Here's what I've tried in terms of troubleshooting:
Are you able to view the block with no other changes on your local setup? Any ideas what I may be missing from my testing? |
|
👋 Hi @SiobhyB, thanks for flagging this. I checked the testing instructions on wordpress-mobile/gutenberg-mobile#3903 and see that I'd listed the wrong commands (e.g. |
SiobhyB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @guarani! I was able to get this working for iOS after running npm run bundle.
The block still doesn't display in the Android app for me with these branches checked out, though. I was only able to get it to work after adding a line of code, which I've included in a comment.
Following the above actions, I was able to confirm that the block is visible from the inserter, search, and slash inserter on both platforms. 🎉 I'll go ahead to approve this PR as soon as the changes are made for Android. Let me know if I'm missing something here, too.
...droid/react-native-bridge/src/main/java/org/wordpress/mobile/WPAndroidGlue/GutenbergProps.kt
Show resolved
Hide resolved
Was bundling needed when testing from within WPiOS or within the Gutenberg Mobile folder? If the former, bundling makes sense if the packager is not running (that said, I don't think testing in the main apps is needed at the moment). If the latter, I'd like to dig into this further.
Thanks for that! Sorry that I didn't catch it myself. I've added your suggested change and it's fixed now. |
SiobhyB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, Paul! I'm now seeing everything work as expected across both platforms and can confirm the "bundle" issue was a mistake on my side.
Approved. :) ![]()
bbdf59c to
c6b1619
Compare
|
Sorry for the mass ping folks 😞 |
|
Size Change: +2.68 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
c6b1619 to
24d7e1a
Compare
24d7e1a to
222fac2
Compare
* Register new block * Enable new block capability
* Register new block * Enable new block capability
Description
Addresses wordpress-mobile/gutenberg-mobile#3903
Adds capability for new Tiled Gallery block in Gutenberg Mobile.
How has this been tested?
See:
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).