[RNMobile] Fix background and text colour on pullquote block#34451
Merged
[RNMobile] Fix background and text colour on pullquote block#34451
Conversation
enejb
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
Member
|
Hey @enejb 👋 thanks for working on this issue! As we discussed internally we could consider making a native variant for Pullquote, since we might need some changes that the core code wouldn't need. On native, every blocks receives within its props the
So we can just pass that to the respective components to show the colors. What do you think? |
enejb
force-pushed
the
rnmobile/fix/pullquote-block-color
branch
from
e05e332 to
57c1d9a
Compare
enejb
force-pushed
the
rnmobile/fix/pullquote-block-color
branch
from
57c1d9a to
56d6a89
Compare
Contributor
Author
|
@geriux can you take another look? |
enejb
force-pushed
the
rnmobile/fix/pullquote-block-color
branch
from
c6ed774 to
3f7b150
Compare
Contributor
Author
|
Thanks for all the feedback @geriux. |
geriux
reviewed
Sep 27, 2021
Member
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
Thanks for the changes @enejb! I left two comments/questions about having the same behavior as web: using the selected text color (or the default text color if none is selected) for the border color.
E.g:
| Before | After |
|---|---|
 |
 |
| Before | After |
|---|---|
 |
 |
What do you think?
enejb
force-pushed
the
rnmobile/fix/pullquote-block-color
branch
from
042fe1f to
bbc9288
Compare
Contributor
Author
|
I really like the change that you suggested. Thanks for all the fixes @geriux ! |
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
enejb
force-pushed
the
rnmobile/fix/pullquote-block-color
branch
from
b6abacf to
9fd9bcf
Compare
geriux
approved these changes
Oct 11, 2021
Member
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! Nice work 👏 🚀 Tested it on both iOS and Android with a standard theme and with a block-based one.
# Conflicts: # packages/react-native-editor/CHANGELOG.md
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34358
This PR still needs more testing on my end.
This PR fixes the color selection for the text and background that was removed in #30951
Description
Adds back the colours for the text and background.
How has this been tested?
Testing selfhosted sites.
6. On a WP 5.8 self hosted site. Create a few different variations of the pull quote.
7. Do the pull quotes look as expected in the editor / similar to the preview.
Screenshots
Types of changes
Bug Fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).