Update cover image markup and CSS#3444
Merged
jasmussen merged 6 commits intoWordPress:masterfrom Mar 13, 2018
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update cover image markup and CSS discussed in #2902.
How Has This Been Tested?
npm testgives error. I can't seem to track down why? It's about"isValid": false,.Screenshots (jpeg or gifs if applicable):
Types of changes
<section>to<div>.<h2>to<p>.<p class="wp-block-cover-image-text">. This was mainly for easier styling in the editor.wp-block-cover-image-text. I have now added it like this:<p className={ classnames( 'wp-block-cover-image-text' ) }>Checklist: