Prevent duplicate queries #32700
Merged
Prevent duplicate queries #32700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing args to WP_Query::__construct method (in this case, but creating a new WP_Query, this one internally executes the WP_Query::get_posts method and stores the result in the WP_Query::posts property. When calling the WP_Query::get_posts again, the same SQL query gets executed, and the result is again stored in the WP_Query::posts property. Originally done in WordPress Core in https://core.trac.wordpress.org/changeset/51144 for https://core.trac.wordpress.org/ticket/53176 with props to jorbin and david.binda.
aaronjorbin
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
Contributor
|
Looks like there's a conflict (need a rebase), but other than that, this is looking good. Thanks for the backport :) |
Member
Author
|
@youknowriad yep, I fixed that up. |
youknowriad
added
[Feature] Full Site Editing
Backport to WP 6.9 Beta/RC
Contributor
|
(Added the backport to core label, just to make sure we include this in |
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
When passing args to WP_Query::__construct method (in this case, but creating a new WP_Query, this one internally executes the WP_Query::get_posts method and stores the result in the WP_Query::posts property. When calling the WP_Query::get_posts again, the same SQL query gets executed, and the result is again stored in the WP_Query::posts property. Originally done in WordPress Core in https://core.trac.wordpress.org/changeset/51144 for https://core.trac.wordpress.org/ticket/53176 with props to jorbin and david.binda.
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
When passing args to WP_Query::__construct method (in this case, but creating a new WP_Query, this one internally executes the WP_Query::get_posts method and stores the result in the WP_Query::posts property. When calling the WP_Query::get_posts again, the same SQL query gets executed, and the result is again stored in the WP_Query::posts property. Originally done in WordPress Core in https://core.trac.wordpress.org/changeset/51144 for https://core.trac.wordpress.org/ticket/53176 with props to jorbin and david.binda.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing args to WP_Query::__construct method (in this case, but creating a new WP_Query, this one internally executes the WP_Query::get_posts method and stores the result in the WP_Query::posts property. When calling the WP_Query::get_posts again, the same SQL query gets executed, and the result is again stored in the WP_Query::posts property.
Originally done in WordPress Core in https://core.trac.wordpress.org/changeset/51144 for https://core.trac.wordpress.org/ticket/53176 with props to jorbin and david.binda.