Fix Legacy Widget block in Customizer #31405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent crash when Legacy Widget block is added to Customizer. - Show Legacy Widget block variations in Customizer. - Prevent hidden widget types from appearing in Legacy Widget block dropdown.
noisysocks
added
[Type] Bug
noisysocks
commented
May 3, 2021
|
Size Change: -1.58 kB (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
noisysocks
requested review from
adamziel,
draganescu and
tellthemachines
as code owners
noisysocks
force-pushed
the
fix/legacy-widget-in-customizer
branch
from
456692d to
36f2dcc
Compare
noisysocks
force-pushed
the
fix/legacy-widget-in-customizer
branch
from
36f2dcc to
f8d2b4d
Compare
talldan
reviewed
May 3, 2021
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Nice work. Tested and this fixes the bugs mentioned in the issue.
There's one thing I spotted. It might be unrelated to this change, but I can't reproduce in trunk (mostly because I can't insert a legacy widget there).
- Install the SiteOrigin bundle plugin
- Open an empty widget area in the customizer
- Add a legacy widget block
- Select SiteOrigin Button option from the dropdown
- Quicky click into the next default block appender (not the + button but the area where the paragraph will be created).
- Editor crashes with the following error
react-dom.82e849f1.js:11237 Uncaught TypeError: Cannot read property 'id' of null
at sidebar-adapter.js:252
at Array.map (<anonymous>)
at SidebarAdapter._updateWidgets (sidebar-adapter.js:251)
at SidebarAdapter.setWidgets (sidebar-adapter.js:275)
at use-sidebar-block-editor.js:186
at basicStateReducer (react-dom.82e849f1.js:15148)
at updateReducer (react-dom.82e849f1.js:15270)
at updateState (react-dom.82e849f1.js:15372)
at Object.useState (react-dom.82e849f1.js:16084)
at useState (react.af754d50.js:1583)
This line of code:
It seems like a race condition, as it only happens when clicking quickly.
Member
Author
|
Good catch! Fixed in 6bab707. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31094.
edit-widgetsandcustomise-widgetsto a newwidgetspackage.How has this been tested?
Checklist:
*.native.jsfiles for terms that need renaming or removal).