Skip to content

components: Fix build #31106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowriad merged 1 commit into from
Apr 22, 2021
Merged

components: Fix build #31106

youknowriad merged 1 commit into from
Apr 22, 2021

Conversation

@sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented Apr 22, 2021

Description

Fixes the type import for polymorphic-components. The file was moved from create-styles to context but it was missed in the previous context PR after PR to remove create-styles was merged (the original context PR needed a rebase)

How has this been tested?

Build passes

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • [N/A] I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@sarayourfriend sarayourfriend self-assigned this Apr 22, 2021
@sarayourfriend sarayourfriend added [Feature] Component System WordPress component system [Package] Components /packages/components [Type] Bug An existing feature does not function as intended labels Apr 22, 2021
@sarayourfriend
Copy link
Contributor Author

sarayourfriend commented Apr 22, 2021

Does anyone know why the compressed size check would fail? Does it depend on trunk being green? 🤔

@mkaz
Copy link
Member

mkaz commented Apr 22, 2021

The action failing is: https://github.com/preactjs/compressed-size-action
So I think yes, it won't pass because it can't build trunk to compare to.

It will probably need a force merge to clear.

@youknowriad youknowriad merged commit 2d60a30 into trunk Apr 22, 2021
@youknowriad youknowriad deleted the fix/context branch April 22, 2021 18:35
@github-actions github-actions bot added this to the Gutenberg 10.6 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees

@sarayourfriend sarayourfriend

Labels

[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 10.6

Development

Successfully merging this pull request may close these issues.

4 participants

@sarayourfriend @mkaz @youknowriad